Fixed version string of repo index

sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s

Eclipse Public License 1.0

97 stars 71 forks source link

Fixed version string of repo index #115

Closed bartmeuris closed 4 years ago

bartmeuris commented 4 years ago

(brief, plain english overview of your changes here)

This pull request makes the following changes:

Changes the apiVersion from '1.0' to 'v1' in the generated repository index, so it's a valid API version, conforming to the helm format. See any index.yaml generated by helm serve or inspect the official helm index.yaml file (warning: 7+mb), or the official examples

Some tools attempt to verify if they are compatible with the version being served and fail on a nexus hosted helm repository.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer(s), Bart Meuris b.meuris@napoleongames.be, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

mlukaretkyi commented 4 years ago

@bartmeuris Hi, could you please follow the instruction and pass CLA

Thanks for the contribution! Unfortunately we can't verify if the committer(s), Bart Meuris b.meuris@napoleongames.be, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

yamansama commented 4 years ago

Hi @bartmeuris, thanks for this merge request ! I'm using some tools that verify the apiVersion, and - as it is not a standard / expected value - I'm completely blocked at the moment... Can you please sign the CLA as mentionned by @mlukaretkyi ? So your request can be reviewed / merged <3

bartmeuris commented 4 years ago

Sorry, I'm having some problems accepting this since I made these commits on a client's laptop, with my mail address in their system (b.meuris@napoleongames.be), which is not linked with my GitHub account (and is also something I can't do).

Edit: I signed this already with my own account.

mlukaretkyi commented 4 years ago

@bartmeuris Hi. No worries, your problem was solved. Please take a look at this If everything ok, please close this PR https://github.com/sonatype-nexus-community/nexus-repository-helm/pull/125