search

sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s
Eclipse Public License 1.0
97 stars 71 forks source link

fix: version string of repo index #125

Closed yamansama closed 4 years ago

yamansama commented 4 years ago

Normalize version to match Helm standard

(brief, plain english overview of your changes here)

This pull request makes the following changes: Changes the apiVersion from '1.0' to 'v1' in the generated repository index, so it's a valid API version, conforming to the helm format. See any index.yaml generated by helm serve or inspect the official helm index.yaml file (warning: 7+mb), or the official examples Some tools attempt to verify if they are compatible with the version being served and fail on a nexus hosted helm repository.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @yamansama to sign the Sonatype Contributor License Agreement.

yamansama commented 4 years ago

Hey guys :) @mlukaretkyi @DarthHater Can you check this ?

yamansama commented 4 years ago

Thanks @bartmeuris :)

ThirtyThirds commented 4 years ago

@bartmeuris thanks for pointing it and the initial Pull Request! @yamansama thanks for taking time re-submitting it.

Hello @mlukaretkyi, @chernikovmaksym, @DarthHater could you please reconsider this PR? This fix is really mandatory to comply with helm index structure and cause many issues with automation.

Thanks :)

macsual commented 4 years ago

I didn't realise that there was a PR for this, before I created this Issue in JIRA: https://issues.sonatype.org/browse/NEXUS-23548

So I guess we should create a link between this PR and the JIRA Issue?

Also, as stated in the JIRA Issue, the incorrect version string format breaks integration with Octopus Deploy when using the Nexus Helm chart repo as a Feed in Octopus.

yamansama commented 4 years ago

Hi @macsual, Yeah good idea ! Oooh glad to meet another Octopus Deploy user ;)

macsual commented 4 years ago

haha @yamansama :)

How do we create/reflect the association between this PR and the JIRA Issue?

aornatovskyy commented 4 years ago

haha @yamansama :)

How do we create/reflect the association between this PR and the JIRA Issue?

@macsual I mentioned current PR in the Jira ticket comment. So once it will be picked to sprint this PR will be used.

Thanks for your contribution.

mlukaretkyi commented 4 years ago

https://issues.sonatype.org/browse/NEXUS-23548