Added support for relative paths inside proxies in generated index.yaml

sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s

Eclipse Public License 1.0

97 stars 71 forks source link

Added support for relative paths inside proxies in generated index.yaml #128

Open tmckeag opened 4 years ago

tmckeag commented 4 years ago

This pull request makes the following changes:

Makes the relative-URL writing in the proxy index generator (IndexAbsoluteUrlRewriter) aware of the URL of the remote repository.
Changes URL rewrite to add appropriate consideration for relative paths inside the proxied repository.
Adds a test case in the relative .yaml test resource to ensure behavior is correct.

It relates to the following issue #s:

https://github.com/sonatype-nexus-community/nexus-repository-helm/issues/127

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer(s), 212486039 tory.mckeag@ge.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @tmckeag to sign the Sonatype Contributor License Agreement.

mlukaretkyi commented 4 years ago

@tmckeag Hi, thanks for your PR. Could you take a look at this issue? https://github.com/sonatype-nexus-community/nexus-repository-helm/issues/94 As far as I understand you try to fix this issue, but I think we need to implement this in a different way. I think you need to take a look at HelmProxyFacetImpl.getCachedContent. My guess, you can rewrite URLs in this method