sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s
Eclipse Public License 1.0
97 stars 71 forks source link

Check license on circle ci #148

Closed aornatovskyy closed 3 years ago

aornatovskyy commented 4 years ago

Ticket: https://issues.sonatype.org/browse/NEXUS-24473

License header check works: https://app.circleci.com/pipelines/github/sonatype-nexus-community/nexus-repository-helm/344/workflows/ca296651-6077-4bd7-b57c-9aca1e5f8d10/jobs/380/steps

bhamail commented 4 years ago

This is thornier than it seems. I found this comment: https://github.com/mycila/license-maven-plugin/issues/36#issuecomment-33956023

And I'm starting to think option number 2 might be the way out of these woods. (Did you ask if Nexus team have other ideas?) You could try option 2 by:

If that works, we could publish the license header jar, and all the format projects could re-use it.

mlukaretkyi commented 3 years ago

will not be relevant after migrating source code helm to nexus