search

sonatype-nexus-community / nexus-repository-helm

At the Helm, Helm Yeah, v k8s
Eclipse Public License 1.0
97 stars 71 forks source link

Enabling Circle Ci integration #54

Closed Darkvar closed 5 years ago

Darkvar commented 5 years ago

Adding config.yml for Circle CI integration Ticket: https://issues.sonatype.org/browse/NEXUS-21033

sonatypecla[bot] commented 5 years ago

Thanks for the contribution! Unfortunately we can't verify if the committer(s), Maksym Kalachov mkalachov@sonatype.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

Darkvar commented 5 years ago

Travis is failing since #52 is not merged yet.

Darkvar commented 5 years ago

@DarthHater please take 2nd look. TravisCI config was removed, CircleCI badge was added (it will be empty till the job is enabled).

Darkvar commented 5 years ago

@DarthHater this PR is waiting for your review

bhamail commented 5 years ago

Very minor optional request: If you have a chance, could you move the .maven.xml file into the .circleci folder, and point the "deploy" target there as well?

See this commit for an example: https://github.com/sonatype-nexus-community/nexus-repository-conda/commit/71434aacd0de175b6a046cb6eef4c74b575f1b50

My +1 still holds with or without this change.

Darkvar commented 5 years ago

Very minor optional request: If you have a chance, could you move the .maven.xml file into the .circleci folder, and point the "deploy" target there as well?

@bhamail I'd prefer to make such change in the separate PR. This PR doesn't contain maven.xml so it's not clear for me.