sonatype-nexus-community / oysteR

Create purls from the filtered sands of your dependencies, powered by OSS Index
https://sonatype-nexus-community.github.io/oysteR/
Apache License 2.0
40 stars 9 forks source link

Refactoring (?) #1

Closed csgillespie closed 4 years ago

csgillespie commented 4 years ago

Hi. I saw your message on the R-pkg mailing list and thought your package looked interested and useful. So I wondered if I could solve your issue. However, I found a few other issues, some of which would have resulted in your package being bounced by CRAN.

The issues I found (and fixed) were

I also fixed

On loading the package you can now:

library(oysteR)
results = audit_deps()
results # Calls an S3 method
View(results)

To be honest, I think the S3 print method is a bit annoying but thought I would demonstrate.

This PR passes all CRAN checks and would probably be accepted, however, please don't submit as is


I realise that this is a ridiculously long, unasked for and not discussed PR. So if you want to close that's fine, I had fun messing about and learning about Sonatype (I'll likely use it in a project). Happy to discuss and contribute further.

sonatypecla[bot] commented 4 years ago

Thanks for the contribution! Before we can merge this, we need @csgillespie to sign the Sonatype Contributor License Agreement.