Hi. I saw your message on the R-pkg mailing list and thought your package looked interested and useful. So I wondered if I could solve your issue. However, I found a few other issues, some of which would have resulted in your package being bounced by CRAN.
The issues I found (and fixed) were
Manipulating the namespace path via library commands
Running functions on loading
Exporting all functions
Using "." for function names, but then exporting them.
I also fixed
Made some of the functions more R like
Used an S3 class for printing
Returned a data.frame/tibble for easier manipulation by users
To be honest, I think the S3 print method is a bit annoying but thought I would demonstrate.
This PR passes all CRAN checks and would probably be accepted, however, please don't submit as is
Docs could be improved
The print.R file contains a bunch of functions that need to be refactored
Then the README needs to be updated
Probably some simple tests
I realise that this is a ridiculously long, unasked for and not discussed PR. So if you want to close that's fine, I had fun messing about and learning about Sonatype (I'll likely use it in a project). Happy to discuss and contribute further.
Hi. I saw your message on the R-pkg mailing list and thought your package looked interested and useful. So I wondered if I could solve your issue. However, I found a few other issues, some of which would have resulted in your package being bounced by CRAN.
The issues I found (and fixed) were
I also fixed
On loading the package you can now:
To be honest, I think the S3 print method is a bit annoying but thought I would demonstrate.
This PR passes all CRAN checks and would probably be accepted, however, please don't submit as is
I realise that this is a ridiculously long, unasked for and not discussed PR. So if you want to close that's fine, I had fun messing about and learning about Sonatype (I'll likely use it in a project). Happy to discuss and contribute further.