sonatype-nexus-community / oysteR

Create purls from the filtered sands of your dependencies, powered by OSS Index
https://sonatype-nexus-community.github.io/oysteR/
Apache License 2.0
40 stars 9 forks source link

[FEATURE] Function names #28

Closed csgillespie closed 3 years ago

csgillespie commented 4 years ago

The function names have become a bit messy. We currently have:

The issues are:

It's confusing (well it confuses me)

Rename the functions! Now is the time to break/deprecate things ;) Here are some quick suggestions, please suggest improvements

cc @bhamail / @DarthHater / @brittanybelle / @adrianpowell / @csgillespie / @JosiahParry

JosiahParry commented 4 years ago

Thanks for raising this, Colin.

Regarding the name audit_deps(), I think this is misleading because it doesn't actually look at dependencies of packages but rather just searches for the package itself.

Disambiguating audit_deps() makes sense. I agree that audit_installed_pkgs() should be it's own function.

Regarding audit_pkgs(), what would you prefer to pass rather than a vector? I think accepting arguments as vectors provides the most flexibility.

Alternate name audit_libs()? audit() is also fine as it's generally a catch all.