search

sonatype-nexus-community / oysteR

Create purls from the filtered sands of your dependencies, powered by OSS Index
https://sonatype-nexus-community.github.io/oysteR/
Apache License 2.0
40 stars 9 forks source link

how is repo used in `expect_secure()`? #49

Open JosiahParry opened 3 years ago

JosiahParry commented 3 years ago

@csgillespie, I'm currently trying to extend the testthat compatibility / functionality and am working off of your existing function. One thing that is not clear is the utility of the repo argument. Other than setting the repo option manually, I cannot figure out what it is used for. Based on my reading it is an unused argument. Can you clairfy?

https://github.com/sonatype-nexus-community/oysteR/blob/0a776638976d9f18e65ad4d17b806cfcceffeef7/R/expect_secure.R#L23

csgillespie commented 3 years ago

Yep this does seem like an odd argument. I think I came across an edge case where {testthat} stripped out the repos

https://github.com/sonatype-nexus-community/oysteR/blob/0a776638976d9f18e65ad4d17b806cfcceffeef7/R/expect_secure.R#L25

JosiahParry commented 3 years ago

Interesting. Perhaps it's my naiveté wrt {testthat}. Does testthat require that option be specified? Within audit_description() I don't think any function requires a repo to be specified. Safe to say I can continue developing omitting this arg unless any issue arises?

csgillespie commented 3 years ago

On Thu, 31 Dec 2020, 17:00 Josiah Parry, notifications@github.com wrote:

Interesting. Perhaps it's my naiveté wrt {testthat}. Does testthat require that option be specified? Within audit_description() I don't think any function requires a repo to be specified.

The check package function calculates the dependency tree of packages. So not just those in the description file. This requires a repo to be specified

Safe to say I can continue developing omitting this arg unless any issue

arises?

It should be obvious if it breaks.

My thinking is that sometimes you would specify a specific repo, eg if you are using a tagged rspm.

I should probably document this😁

—

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sonatype-nexus-community/oysteR/issues/49#issuecomment-753006094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVQI3CYZIQLLF6G66YVALSXSU35ANCNFSM4VPSBH2Q .