sonatype-nexus-community / oysteR

Create purls from the filtered sands of your dependencies, powered by OSS Index
https://sonatype-nexus-community.github.io/oysteR/
Apache License 2.0
40 stars 9 forks source link

Dev: Licence at the top of each R file #7

Closed csgillespie closed 4 years ago

csgillespie commented 4 years ago

Typically in R packages, the DESCRIPTION contains the licence/copyright and so the header isn't required. Your package has the Apache 2 in the DESCRIPTION, so is it needed for the files?

Proviso: I know nothing about licences

DarthHater commented 4 years ago

For Apache it's not strictly necessary, they are of the opinion that just having one attached to the repo is enough. However, we tend to do it anyways so that:

We can survive without it with Apache, but the benefits of attaching it seem to outweigh not attaching it. Would love anyone else's perspective!

DarthHater commented 4 years ago

@csgillespie I talked with our CTO about this, and the statement:

the files really should have the header, the logic being if the file gets separated from the project, one could claim they didn’t know the license

That was more or less my second point. I'd say let's add them, and go from there!

csgillespie commented 4 years ago

OK, I'll add them in the near future. One further note, when you install an R package I'm 99% sure that all comments are stripped from the R files ;)

DarthHater commented 4 years ago

Yeah, I figured, it only really matters for the source repo tho, in case you have driveby people grabbing stuff.