sonatype-nexus-community / oysteR

Create purls from the filtered sands of your dependencies, powered by OSS Index
https://sonatype-nexus-community.github.io/oysteR/
Apache License 2.0
40 stars 9 forks source link

Dev: Add test suite #8

Closed csgillespie closed 4 years ago

csgillespie commented 4 years ago

Need test for call_oss_index()

DarthHater commented 4 years ago

@csgillespie , hey! @brittanybelle and I added this test back in today, and we got it to fail, which is great.

We noticed that when we run it, the test shows 95 total projects, but if it's truly using the saved json it should be 99. This may or may not be related to your changes, so it might be worth a look!

Cheers!

csgillespie commented 4 years ago

Good spot! The issue is due to the API not always returning a description (https://github.com/sonatype-nexus-community/oysteR/blob/master/tests/testthat/ossindex.sonatype.org/api/v3/component-report-cb1057-POST.json#L353)


Fix to follow.