search

sonatype-nexus-community / scan-gradle-plugin

Gradle plugin that scans the dependencies of a Gradle project using Sonatype platforms: OSS Index and Nexus IQ Server.
Apache License 2.0
77 stars 22 forks source link

Update to Gradle 8.8 #165

Closed guillermo-varela closed 1 month ago

guillermo-varela commented 2 months ago

Goes up until the more recent Gradle version we can use without introducing breaking changes.

I'd prefer to deal with those changes later when we upgrade to Gradle 9 (which isn't yet at GA).

cc @bhamail / @DarthHater / @shaikhu

guillermo-varela commented 1 month ago

There is a known issue with Gradle and multi-jar dependencies on plugins, which happen to be the case of Jackson as of version 2.15.0-rc1.

While a workaround could be using resolution strategy to force a downgraded version it's hard to determine the impact (specially medium/long term) of using an older dependency version.

It migth be better just to work with what Gradle allow us to on each version where they fixed (or backported) the issue:

f82df5c0a43a4251159a347baffb3149fc3a2d05 adds tests for the known Gradle version this plugin would be able to support.

shaikhu commented 1 month ago

There is a known issue with Gradle and multi-jar dependencies on plugins, which happen to be the case of Jackson as of version 2.15.0-rc1.

While a workaround could be using resolution strategy to force a downgraded version it's hard to determine the impact (specially medium/long term) of using an older dependency version.

It migth be better just to work with what Gradle allow us to on each version where they fixed (or backported) the issue:

Fully in agreement with this. We probably need to update the readme or version 3 of this plugin, to state which gradle versions are supported.

guillermo-varela commented 1 month ago

We probably need to update the readme or version 3 of this plugin, to state which gradle versions are supported.

Please check if this is good enough: https://github.com/sonatype-nexus-community/scan-gradle-plugin/pull/165/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

paul-botsco-2-0[bot] commented 1 month ago

Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set.

The commits to review are: