search

sonatype / chef-nexus-repository-manager

Chef recipes for Nexus Repository Manager
Other
45 stars 28 forks source link

Get chef-nexus-repository-manager into Supermarket #30

Open Brantone opened 6 years ago

Brantone commented 6 years ago

When initially setting up a Chef+Nexus instance, this repo was not found in Supermarket : https://supermarket.chef.io/cookbooks/nexus Is there a timeline for getting it into the Supermarket?

Brantone commented 6 years ago

@whyjustin Fwiw, was looking at adding ticket to https://issues.sonatype.org/browse/INT but obviously not possible for external people. In addition to curiosity about Chef Supermarket, is there a prescribed method for reporting issues and contributing? (ex: CONTRIBUTING.md?) Thx in advance

poblahblahblah commented 6 years ago

The sonatype support folks were very unhelpful with this so to move our internal project past this small hurdle I went ahead and uploaded the code to supermarket.

https://supermarket.chef.io/cookbooks/nexus_repository_manager

Please let me know who to grant access to.

Brantone commented 6 years ago

Kinda surprised they allowed it considering not repo maintainer, but hey, glad it's up there. I'll stick my hand up for access, please.

whyjustin commented 6 years ago

Kinda surprised they allowed it considering not repo maintainer

I am surprised as well.

The sonatype support folks were very unhelpful

Thank you for being proactive and getting this on the Chef Supermarket. The decision to delay our response was calculated as moving it to the Chef Supermarket involves maintaining and supporting the offering. It may seem nuanced but this is slightly different from open sourcing a cookbook we use internally on GitHub.

I plan on leaving this issue open until we are able and willing to assume ownership of the recipe in the Supermarket.

poblahblahblah commented 6 years ago

The decision to delay our response was calculated as moving it to the Chef Supermarket involves maintaining and supporting the offering. It may seem nuanced but this is slightly different from open sourcing a cookbook we use internally on GitHub.

Understood - I felt like I was getting the runaround from Support since they said they "We aren't the authors of that cookbook, you'll need to contact the people that wrote it." which was strange because the code is under the Sonatype org, and this blog post on the sonatype blog discussed open sourcing it.

I'll happily transfer ownership over to ya'll once you are ready, but I needed a path to move forward and without an explanation as to why this wasn't being done and since it was being requested I figured there wouldn't be much harm.

edwardbartholomew commented 6 years ago

@whyjustin Would you/Sonatype consider updating versions in metadata.rb and tagging releases to help those of us pinning to github? I think this would also help managing versions in the Supermarket in the interim.

whyjustin commented 6 years ago

@edwardbartholomew The versions are tagged and released (see [0]). I'll schedule updating the metadata.rb file in our delivery pipeline.

[0] https://github.com/sonatype/chef-nexus-repository-manager/releases/tag/release-0.5.20180420-205540.75aa3de

edwardbartholomew commented 6 years ago

Thanks - I noticed that as I was posting. If you will update metadata.rb version same as your tagged release, it won't follow Chef standards (not sure if would cause any issue with knife/berks). From https://docs.chef.io/cookbook_versions.html, 

A cookbook version always takes the form x.y.z, where x, y, and z are decimal numbers that are used to represent major (x), minor (y), and patch (z) versions. A two-part version (x.y) is also allowed. Alphanumeric version numbers (1.2.a3) and version numbers with more than three parts (1.2.3.4) are not allowed.

But you are right, you have releases tagged so I can pin according to that now.

edwardbartholomew commented 6 years ago

Just saw another release, any movement on this issue or #38 ?