sonatype / install4j-support

Install4j Support
http://sonatype.github.io/install4j-support/
11 stars 11 forks source link

Add suport to "--preserve" parameter #24

Closed FABH closed 9 years ago

FABH commented 9 years ago

This parameter is used to keep the temporary files created by Install4j. This option is not showed in --help, but its mentioned in http://stackoverflow.com/a/32273724/3385457.

Its possible to include it?

jdillon commented 9 years ago

will have a look, annoyed that --help does not show all the flags, they had a few others not shown too that i've asked them to add in the past.

ingokegel commented 9 years ago

I'll add it to the help in 6.0.5. What were the other missing flags? The system properties are not documented by the --help output.

jdillon commented 9 years ago

@ingokegel the only recent one I know about is -J but I mentioned that to you guys already. I'm not sure what other flags there are so I can't say, but knowing there was one before, and now is another, I'm not sure there aren't any more :-P

jdillon commented 9 years ago

Also added support for:

--disable-bundling
--incremental
jdillon commented 9 years ago

@FABH if you can give it a try and see if its working as expected, and I'll prepare a release.

@ingokegel if there are any other hidden flags please do try and update the --help output, and/or let me know if there are any that would be important to include in the maven integration.

ingokegel commented 9 years ago

I can't see any others, just "preserve" was missing. It was not hidden intentionally, we just forgot about it.

jdillon commented 9 years ago

@ingokegel thx

FABH commented 9 years ago

Tested the master branch and it worked!