search

sonatype / install4j-support

Install4j Support
http://sonatype.github.io/install4j-support/
11 stars 11 forks source link

ConfigureProxyAction shows download details on console #8

Closed jdillon closed 12 years ago

jdillon commented 12 years ago 
// Trigger a file download action, so that proxy configuration can be detected
log.debug("Detecting proxy configuration");
DownloadFileAction action = new DownloadFileAction();
action.setUrl("http://www.google-analytics.com/__utm.gif"); // just use the tracker's base url w/o any params
action.setAskForProxy(true);
action.setDeleteOnExit(true);
action.setRetryIfInterrupted(true);
action.setShowFileName(false);
action.setShowProgress(false);
action.setShowError(false);
action.setTargetFile(File.createTempFile("configure-proxy", ".tmp").getAbsolutePath());
action.execute(context);

I believe this should disable any progress display, but I still see some:

Starting Installer ...
0.0 MB of 0.0 MB (100.0%) at 17.1 kb/s

The "0.0 MB of 0.0 MB (100.0%) at 17.1 kb/s" here is the DownloadFileAction action executions output.

I had expected that if "action.setShowProgress(false);" that it would not emit any of these details.

jdillon commented 12 years ago

Fixed in 8d9d8e96a96f4746a6425fdd11d7952f0cf97a0d

Requires install4j 5.1.3