search

sonatype / nxrm3-ha-repository

Repository for YAML configuration files for Nexus Repository Manager High Availability Feature
16 stars 17 forks source link

Allow specifying custom imagePullSecrets #44

Open HaniAlshikh opened 6 months ago

HaniAlshikh commented 6 months ago

Hi,

can you please explain the reasoning behind this:

https://github.com/sonatype/nxrm3-ha-repository/blob/cdbda4f36c9e2c4299377792e01101b437c08ac6/nxrm-ha/templates/statefulset.yaml#L62

As far as i can see there is no way to "manually" create {{ template "nexus.name" . }}-imagepullsecret without providing the credentials in plain text, since image-pull-secret.yam will be used as soon as an imagePullSecret is specificed

https://github.com/sonatype/nxrm3-ha-repository/blob/cdbda4f36c9e2c4299377792e01101b437c08ac6/nxrm-ha/templates/image-pull-secret.yaml#L1

and the only way to provide the credentials is in plain text: https://github.com/sonatype/nxrm3-ha-repository/blob/cdbda4f36c9e2c4299377792e01101b437c08ac6/nxrm-ha/templates/image-pull-secret.yaml#L15

HaniAlshikh commented 6 months ago

I created a PR to allow the usage of custom imagePullSecrets and kept the possibility of providing the credentials directly to avoid breaking changes.

Hope this can be reviewed and released soon, as it is a blocker for us and it prevents us from deploying Nexus RM.

sylvaindd commented 4 months ago

Hi, I manage my imagePullSecrets externally and could use this feature as well