sonatype / nxrm3-ha-repository

Repository for YAML configuration files for Nexus Repository Manager High Availability Feature
17 stars 23 forks source link

Refactoring docker ingress annotations #63

Closed renesch-de closed 6 months ago

renesch-de commented 7 months ago

The annotations in the 'ingress' section are not used anymore for docker ingress objects. They are now part of an Values.nexus.docker.registries entry. With this change its now possible to define annotations on a docker registry level. This is helpfull if annotations like external-dns.alpha.kubernetes.io/hostname must be used, where each hostname is distinct for each ingress object created.

renesch-de commented 7 months ago

At the moment this is a simple refactoring by separating the annotations for the UI and the Docker-Registry ingress objects. In future, it would be even better to refactor the ingress annotation handling in general, so that the following is possible: