search

sonatype / ossindex-public

Sonatype OSS Index - Public
Apache License 2.0
6 stars 9 forks source link

Clarify on the status of a CLA requirement to contribute #17

Open sschuberth opened 4 years ago

sschuberth commented 4 years ago

I believe the origin of the change is fairly clear with the comment and link to the PR and discussion.

As mentioned, I disagree. There's a reason why Git makes a difference between the author and the committer, and I'm not the author of these commits anymore.

I believe I prematurely consumed your change without first checking your CLA status

I wasn't even aware that signing a CLA is necessary! Neither the README.md nor any CONTRIBUTING.md mentions this. If signing a CLA is required, I urge you to add an according check e.g. via https://github.com/cla-assistant/cla-assistant. Or better yet, use the DCO and https://github.com/probot/dco instead.

Anyway, if I knew a CLA needs to be signed, I wouldn't have contributed. I need to make up my mind what to do now that the contribution already happened.

We will revisit our process for consuming changes to see if we can make any improvements in this area.

Thank you, and yes please, your process needs to be revisited and changed so that authorship in Git history is maintained.

Originally posted by @sschuberth in https://github.com/sonatype/ossindex-public/pull/6#issuecomment-540136428

sschuberth commented 4 years ago

Also, is there a Corporate CLA in addition to https://sonatypecla.herokuapp.com/sign-cla?

azrdev commented 5 months ago

Apparently the normal CLA isn't even there yet, https://sonatypecla.herokuapp.com/sign-cla gives me "There's nothing here, yet. "