search

sondr3 / generator-jekyllized

A Yeoman generator for Jekyll to rapidly build sites using Gulp
MIT License
326 stars 35 forks source link

dot files supported by jekyll not supported in generator config #141

Closed placenamehere closed 8 years ago

placenamehere commented 8 years ago

While the jekyll default config has support for some dot files (such as .htaccess) they were not being moved from src to tmp on the copy steps that precede the jekyll processing, so any build or deploy I was doing was not inclusive of these files.

Locally, I fixed this by adding ,{dot: true} to the appropriate gulp.src() calls in my gulpfile.js.

placenamehere commented 8 years ago

digging into how gulpfile.js is being generated it looks like the fix would be needed to both the move to tmp task in generator-jekyllized as well as the deploy task which is inherited from generator-statisk:

https://github.com/sondr3/generator-jekyllized/blob/master/generators/jekyll/templates/build.js#L10 https://github.com/sondr3/generator-statisk/blob/master/generators/gulp/templates/tasks/uploading.js#L50

sondr3 commented 8 years ago

Thanks! Didn't think about this as I don't use Apache or anything requiring dotfiles, I'll fix this one as well as soon as I can!

sondr3 commented 8 years ago

Okay, so I'm fixing this one right now but do we need to add support for dotfiles to both GitHub Pages and Amazon AWS? As far as I know neither of those have any files that are dotfiles, whereas for rsync you might need them for Apache and such. Any feedback?

placenamehere commented 8 years ago

I tend to always lean towards predictability -- if part of the process copies files into a staging location (dist) I'd expect the second half of the process to always be configured to work against all those files.

Yes, probably not needed for github or aws (that I know of) but if a developer using this has one in their project it should probably be deployed (and then ignored by the 'server')

I'd say that because this choice/config is buried in a dependent package I'd also lean towards being more accepting in that package by default.

sondr3 commented 8 years ago

Alright, sounds good to me, I'll update them and push a new version pretty soon.

sondr3 commented 8 years ago

And done! I accidentally tagged the wrong commit so I'll have to close it myself, I'll create a new release of both generators ASAP.

sackwort commented 8 years ago

My .htaccess file is not being copied into 'dist' when I run 'gulp build'. I'm using latest RC. I've also tried adding as an include in _config.

sondr3 commented 8 years ago

Crap, I can see why, when updating your app it only looks at what has changed from generator-statisk and not from this generator, I'll fix this as soon as I can, but it might take a few days, in the mean time the second comment here includes a fix.

sackwort commented 8 years ago

There's no rush. Thanks for your great work.

sondr3 commented 8 years ago

I just pushed a new version to Github, you can update to it with npm install -g generator-jekyllized and then run yo jekyllized:update in your project root folder so it correctly updates all your gulp tasks.