sonelu / roboglia

Robotics framework
GNU General Public License v3.0
0 stars 1 forks source link

Explicit is better than implicit #29

Closed sonelu closed 4 years ago

sonelu commented 4 years ago

Completely re-write the constructors for all classes that were using the 'init_dict' approach. Document all parameters and re-write the comments on most of the classes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.80%. The diff coverage is 87.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   89.43%   90.24%   +0.80%     
==========================================
  Files          23       23              
  Lines        1467     1568     +101     
  Branches      189      213      +24     
==========================================
+ Hits         1312     1415     +103     
+ Misses        117      108       -9     
- Partials       38       45       +7     
Impacted Files Coverage Δ
roboglia/dynamixel/bus.py 84.31% <71.87%> (-2.05%) :arrow_down:
roboglia/base/robot.py 93.16% <78.72%> (-5.54%) :arrow_down:
roboglia/base/device.py 92.10% <82.35%> (-7.90%) :arrow_down:
roboglia/base/bus.py 87.17% <86.36%> (-4.49%) :arrow_down:
roboglia/dynamixel/sync.py 89.65% <87.50%> (+7.04%) :arrow_up:
roboglia/dynamixel/register.py 91.66% <88.23%> (-8.34%) :arrow_down:
roboglia/base/joint.py 95.34% <88.46%> (-4.66%) :arrow_down:
roboglia/base/register.py 93.33% <91.89%> (-6.67%) :arrow_down:
roboglia/i2c/bus.py 98.54% <93.33%> (+12.40%) :arrow_up:
roboglia/utils/checks.py 96.96% <94.44%> (-3.04%) :arrow_down:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e995719...1a7264c. Read the comment docs.

sonelu commented 4 years ago

Fixes #8