search

sonelu / roboglia

Robotics framework
GNU General Public License v3.0
0 stars 1 forks source link

[FEATURE REQUEST] Extend the "explicit better than implicit" and reduce use of **kwargs #69

Open sonelu opened 4 years ago

sonelu commented 4 years ago

Is your feature request related to a problem? Please describe. Many classes use **kwargs and only define in the constructor the parameters they use, passing the rest to the super(). This makes for uncomfortable reading of the documentation and understanding of the parameters that need to be supplied to constructor.

Describe the solution you'd like Even though it might tedious, we should copy the parameters from super classes into classes and eliminate the **kwargs.

Describe alternatives you've considered Using the **kwargs makes for shorted code, but less clear and passing misspelled arguments (ex. from YAML) goes unnoticed while the function they are supposed to provide is defaulted.

Additional context Check for instance the Joint, JointPV, JointPVL.

sonelu commented 4 years ago

Changes made for base.thread.BaseThread and all subclasses (including Syncs and Script).

Rest of classes to be updated in v0.2.0