Closed GoogleCodeExporter closed 9 years ago
Original comment by Ben.Manes@gmail.com
on 26 Feb 2009 at 1:53
The majority of this is noise. The ones regarding fields being package private
is to
allow verification of the internal state by the unit tests. If the unit tests
are
not migrated into any project that integrates this data structure, then those
fields
can be made private.
The constants warnings in regards to AtomicUpdaters is, well, opinion and I
followed
j.u.c. as a reference. For example, see ConcurrentLinkedQueue.
The rest seem to expect documentation on every single field and method. That
seems a
bit much. It seems like checkstyles was run with the default settings and not
customized for common-sense usage.
I'll review these, but its low priority.
Original comment by Ben.Manes@gmail.com
on 26 Feb 2009 at 2:01
Original comment by Ben.Manes@gmail.com
on 1 Mar 2009 at 8:59
I ran CheckStyles and PMD, and made minor changes. Most of the stylistic issues
found I am considering noise.
I ran FindBugs, which found no issues.
Original comment by Ben.Manes@gmail.com
on 23 May 2009 at 4:42
Original issue reported on code.google.com by
Ben.Manes@gmail.com
on 26 Feb 2009 at 1:53