songdejia / Siamese-RPN-pytorch

This is a re-implementation of Siamese-RPN with pytorch, which is CVPR2018 spotlight.
MIT License
381 stars 88 forks source link

Make debugging and checking optional through arguments #32

Open Cosmopal opened 5 years ago

Cosmopal commented 5 years ago

Currently, in both code and code_v1.0, debugging and checking is enabled, which results in a lot and lot of images being written to the disk which are just intermediate steps in the training/testing process of the model

(This is as far as I could understood, please correct me if I am wrong). My understanding is that the outputs 0_check_label 1_padding_img_with_detection_and_target 2_cropped_detection 3_resized_detection 4_pos_neg_anchors 5_all_anchors are all outputs representing intermediate steps and are not required for the actual training/testing)

1) Need to make this optional. The user might not want the output. For reasonable size datasets, this debug output itself is into order of 100s of GBs... (personal experience using this model for training)

2) Add in the Readme that this output is in fact a debug output..

Small changes, I can do that..

Cosmopal commented 5 years ago

Just noticed, it's already added as part of options in code_v1. Thanks. Please delete this issue if possible..

Cosmopal commented 5 years ago

We can probably just add it in the readme that the images written are debug images and not required for training...