Open songivan00 opened 1 year ago
A phone number can be reused by different user (eg when a user change sim card and that number is reused by the provider for another user), so it cannot be considered as a unique identifier to detect duplicates.
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
Team chose [type.FeatureFlaw
]
Originally [type.FunctionalityBug
]
Reason for disagreement: [replace this with your explanation]
Two different contact can have the same phone number, when in reality this should not happen and a error message should be thrown.
Steps to reproduce: add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 c/3.50/4.00 g/male u/Nanyang Polytechnic gd/05-2024 m/Computer Science ji/173296 jt/Software Engineer Intern t/rejected t/KIV add n/Test p/98765432 e/test@example.com a/311, test Ave 2, #02-25 c/3.50/4.00 g/male u/Nanyang Polytechnic gd/05-2024 m/Computer Science ji/test jt/Software Engineer Intern t/rejected t/KIV
Expected: Error thrown as same phone number used
Actual: Both contact added