songivan00 / pe

0 stars 0 forks source link

Inconsistency in error messages involving indexing #4

Open songivan00 opened 1 year ago

songivan00 commented 1 year ago

There is an inconsistency in the error messages involving invalid index. When an invalid index 0 is used compared to when an invalid index greater than the contact list is used, there are two separate error messages. Screenshot 2022-11-11 at 4.36.31 PM.png Screenshot 2022-11-11 at 4.36.44 PM.png

Steps to reproduce are shown in the picture and the expected output should be the same error messages as the two errors are the same

soc-pe-bot commented 1 year ago

Team's Response

The error message for view 0 already accounts for the invalid index provided, evidenced by this excerpt below

image.png

Both error messages for view 0 and view 15 still address that these indexes are invalid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that these are two of the same type of errors where the keyed in index is not in the range of the list, and so the error message should be consistent (same format and description). I think it just helps the app look more consistent and hence it is just a cosmetic issue and a verLow severity.