search

songkick / oauth2-provider

Simple OAuth 2.0 provider toolkit
MIT License
526 stars 146 forks source link

Fixed deprecation warning on set_table_name #21

Closed lvonk closed 12 years ago

lvonk commented 12 years ago

For people using active_record >= 3.2

jcoglan commented 12 years ago

Can this be feature-detected so that the code continues to work on older ActiveRecord versions?

Also, I'd prefer keeping your editor's files out of .gitignore. Use you global .gitignore file to keep your editor artifacts out of all projects.

lvonk commented 12 years ago

I didn't upgrade the active record version in the gemspec, all test still run with the current one which is 3.0.0. Are there some tests missing?

Do you want me to send a new pull request or do you remove it yourself from .gitignore?

jcoglan commented 12 years ago

The gem needs to work on 2.x-series releases as well, I'll check what that means for this problem when I'm back at work next week.

jcoglan commented 12 years ago

As it turns out it's incredibly annoying to try to get a test suite to run against Rails 3 and Rails 2. In some cases it's almost impossible. I've testing this by hand and it looks okay, so I'm merging.