search

songkick / oauth2-provider

Simple OAuth 2.0 provider toolkit
MIT License
528 stars 148 forks source link

Remove duplicate ActiveRecord dependency #84

Closed sgerrand closed 9 years ago

sgerrand commented 9 years ago

:information_desk_person: The gemspec defines ActiveRecord as a dependency twice, the second of which attempts to ensure that a compatible version is available for development. Migrating this version lock to the Gemfile results in the same behaviour, without the inconvenience of Bundler >= v1.10.1 refusing to install the gem due to an invalid gemspec.

An example of this error message follows:

/opt/rubies/2.2.2/gems/bundler-1.10.3/lib/bundler.rb:374:in `rescue in load_gemspec_uncached':
The gemspec at /www/sites/demo/vendor/bundle/ruby/2.2.2/bundler/gems/oauth2-provider-b60ea985a0e9/songkick-oauth2-provider.gemspec
is not valid. The validation error was 'duplicate dependency on activerecord (~> 3.2.0, development), (>= 0) use: (Bundler::InvalidOption)
    add_runtime_dependency 'activerecord', '~> 3.2.0', '>= 0'
sgerrand commented 9 years ago

:wave: @VivienBarousse: would you please review these changes. :smiley_cat:

VivienBarousse commented 9 years ago

@sgerrand Looks good, thank you!

sgerrand commented 9 years ago

:dancers: :bow: