songyouwei / ABSA-PyTorch

Aspect Based Sentiment Analysis, PyTorch Implementations. 基于方面的情感分析,使用PyTorch实现。
MIT License
2.01k stars 524 forks source link

Update dependency_graph #196

Closed prasys closed 3 years ago

prasys commented 3 years ago

Problem Statement: The dependency graph.py to generate .graph that is used for ASGCN is currently hardcoded. This prohibits new data set from being used. To make it more dynamic, I have made dependency-graph to specify the location of the dataset that requires processing

I've tested this on custom data sets and it makes it easier to do the processing.

Moving forward, I'll also include different spacy NLP model and also make it dynamic

yangheng95 commented 3 years ago

Nice job! But have you tried to embed this script as an interface? e.g., Call the process function in the datautils.py to generate the graph file if the ASGCN is specified?

prasys commented 3 years ago

Thanks @GeneZC for reviewing, I just plan to keep it in smaller changes. However if needed to be, I can merge it together with the other changes (i.e datautils.py) to be updated

@yangheng95 - I am working on that bit. Let me test it out if it's okay - I'll just submit another PR Request

yangheng95 commented 3 years ago

Good! In case of any help, you can refer to here

songyouwei commented 3 years ago

@all-contributors please add @prasys for code

allcontributors[bot] commented 3 years ago

@songyouwei

I've put up a pull request to add @prasys! :tada: