search

sonia-auv / provider_hydrophone

Allow to communicate with hydrophone
GNU General Public License v3.0
0 stars 1 forks source link

Feature/dockerize project #6

Closed kevincharbonneau closed 4 years ago

kevincharbonneau commented 4 years ago

Description

This modification fixes the implementation of the Dockerfile. As it was tested on : proc_mapping the problem was that ROS was not properly instanciated.

This PR simply changes the Dockerfile to fix the problem.

It also adds remote container setup.

Fixes

Link all the related issues from the issue tracker

How has this been tested ?

  1. start a ros-master : $ docker run --network host ros:melodic-ros-core stdbuf -o L roscore -t ros-master
  2. connect to ros-master : $ docker exec -it ros-master bash 
    $ root@docker-desktop:/# source /opt/ros/melodic/setup.bash
$ root@docker-desktop:/# rosnode list
/provider_hydrophone
/rosout
$ root@docker-desktop:/# rosnode kill provider_hydrophone
killing /provider_hydrophone
killed

    Checklist

    • [x] My code follows the style guidelines of this project
    • [x] I have performed a self-review of my own code
    • [x] I have commented my code, particularly in hard-to-understand areas
    • [x] I have made corresponding changes to the documentation
    • [x] My changes generate no new warnings