search

soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
73 stars 22 forks source link

Allow overriding of interpreter used to run remarshal, support Windows #1

Closed gmishkin closed 4 years ago

gmishkin commented 4 years ago

There are actually two changes here.

The first change is to add a python_interpreter attr that's used to run remarshal.par. This logically matches the same attr of pip_import in the official rules.

The second change is to add support for Windows, where py_binary rules are built into .exe's that don't require the interpreter to be specified for running @pip_archive//:pip. Also in support of Windows, I pass - instead of /dev/stdout, which remarshal documents as being equivalent.

NathanHowell commented 4 years ago

@gmishkin looks great, thanks! I add all PR authors as project contributors, accept or decline as you wish 👍