search

soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
72 stars 22 forks source link

Do not add dependencies to some ignored Poetry libraries #2

Closed nlewo closed 4 years ago

nlewo commented 4 years ago

Otherwise, the generated py_binary targets depend on non existing dependencies (such as setuptool).

Poetry doesn't add several packages in the poetry.lock file: https://github.com/python-poetry/poetry/blob/d2fd581c9a856a5c4e60a25acb95d06d2a963cf2/poetry/puzzle/provider.py#L55 See also https://github.com/python-poetry/poetry/issues/1584 for explanations.

nlewo commented 4 years ago

thanks for the fixes! this has some common logic with

https://github.com/soniaai/rules_poetry/blob/5e50f92254ded3c4198b1e9001347abc7827a2a7/rules_poetry/poetry.bzl#L68

Oh I have not seen this part;) I pushed a new patch appending some libraries to the excludes list.

nlewo commented 4 years ago

@NathanHowell cool! Thank you.