search

soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
72 stars 22 forks source link

Fix bazel crash with missing group dependencies in `pyproject.toml` #21

Closed xinbinhuang closed 1 year ago

xinbinhuang commented 1 year ago

In #18, an optional group keyword was introduced. However, bazel crashes when the pyproject.toml is missing group dependencies. This'll will fix the issue by making group dependencies as optional.

cc: @NathanHowell

njlr commented 1 year ago

LGTM :+1:

The current implementation passes the tests, so perhaps we should add another test case that covers this?

NathanHowell commented 1 year ago

@xinbinhuang also looks good to me, minus tests.. is this something you can add?

xinbinhuang commented 1 year ago

@NathanHowell just added tests. PTAL.

NathanHowell commented 1 year ago

@xinbinhuang thanks!