search

soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
73 stars 22 forks source link

Proposal: Deprecate this package #25

Open AndrewGuenther opened 1 year ago

AndrewGuenther commented 1 year ago

The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry

In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.

njlr commented 1 year ago

The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry

In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.

This is indeed much simpler!

I was wondering if/how your solution handles different platforms? I think we need to do an export per platform?

Additionally, perhaps your method should be merged into this repo?

SimonBiggs commented 1 year ago

Additionally, perhaps your method should be merged into this repo?

It looks like contributions to this repo are a bit of a dead end:

https://github.com/soniaai/rules_poetry/pull/23#issuecomment-1500908949

Thanks @AndrewGuenther for your re-implementation. I'll run with that.