soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
73 stars 22 forks source link

Support for package.source #4

Closed sjoerdvisscher closed 4 years ago

sjoerdvisscher commented 4 years ago

I found out that rules_poetry does not support package.source.

How hard would it be to add this? I only need support for private repositories (one that implements https://www.python.org/dev/peps/pep-0503/), so not git or directories as mentioned in https://github.com/soniaai/rules_poetry/blob/master/rules_poetry/poetry.bzl#L87

Edit: I added args.add("-i") args.add("...my_repo_url...") here https://github.com/soniaai/rules_poetry/blob/master/rules_poetry/defs.bzl#L138 and that worked, so this doesn't seem too hard.