search

soniaai / rules_poetry

Bazel rules that use Poetry for Python package management
MIT License
73 stars 22 forks source link

Support for package.source #5

Closed sjoerdvisscher closed 4 years ago

sjoerdvisscher commented 4 years ago

Fixes issue #4

Note that I'm not sure if checking that the source type is legacy is the right thing to do, that just happened to be the value in my case.

sjoerdvisscher commented 4 years ago

I tried, but that doesn't work nicely with generating code using a template. (It seems you came to the same conclusion with marker, which also has the empty string as default.)

NathanHowell commented 4 years ago

makes sense, thanks for the PR