search

soniakeys / graph

Simple and fast graph library
72 stars 7 forks source link

Overflow error in graph #41

Closed app-git-hub closed 8 years ago

app-git-hub commented 8 years ago

Hi Sonia,

I am getting:

C:\Projects\Go\gd\gdrive>go build
# github.com/soniakeys/graph
..\..\src\github.com\soniakeys\graph\bits.go:71: constant 285870213051353865 ove
rflows big.Word

I am on windows 32-bit, can you help fix that for windows users?

soniakeys commented 8 years ago

Yep. It's hard coded to 64 bits currently out of sheer laziness. I'll try to verify the (expected) error with a 32-bit build, add a 32-bit build to travis, then add the fix. Shouldn't take long, lemme fix some coffee first.

soniakeys commented 8 years ago

Fixed. Thank you for filing this! Please reopen if it's still not working for you.

soniakeys commented 8 years ago

Err, there was a bug...deleted which made things worse...but it should be fixed now.

willemw12 commented 8 years ago

Still an issue on "linux_arm":

$ go get github.com/prasmussen/gdrive
# github.com/soniakeys/graph
../go/src/github.com/soniakeys/graph/bits64.go:56: constant 285870213051353865 overflows big.Word
soniakeys commented 8 years ago

I pushed a change to recognize arm but I have no way of testing it. If you (or anyone) can confirm it working on arm that would be wonderful.

willemw12 commented 8 years ago

It's working now on "linux_arm".

soniakeys commented 8 years ago

awesome. thank you!