search

soniakeys / meeus

Implementation of "Astronomical Algorithms" by Jean Meeus
MIT License
342 stars 56 forks source link

Unit test apsis.ExampleApogee should not be passing #18

Open shawnlauzon opened 4 years ago

shawnlauzon commented 4 years ago

I'm working on a port of your great library to Dart https://github.com/shawnlauzon/meeus. While doing that, I noticed that one of my ported tests failed which seems correct. Both implementations generate the same JD: 2447442.3543003574. However, your test thinks that this is 1988 October 7, at 20ʰ30ᵐ TD, but in fact the time is 20:30:12. I have confirmed this with https://www.aavso.org/jd-calculator and it's the same result that my code produces.

My guess is that sexa.FmtTime is truncating the seconds part for this case, but I don't know why that would be.

sbinet commented 3 years ago

@soniakeys died a few years ago.

shawnlauzon commented 3 years ago

🥺 Wow, so sorry to hear that