Refactor/optimized deploy

NathanGrenier commented 9 months ago

🛠 Proposed Changes:

Fixed swerve drive calibration and optimized files being deployed to the RIO.

📝 Details:

Removed code calibration of swerve module offsets.
Moved all code that needs to be deployed to /src

🔗 Related Issue(s):

Resolves #15 (Not sure if it fully resolves this issue)

NathanGrenier commented 9 months ago

This branch still needs it's swerve code refactored (lots of unused code and comments)

NathanGrenier commented 9 months ago

There seems to be a bug with the basic pyfrc tests. The action will run the test step forever.

I've also encountered this bug when deploying to the physical bot. For now, I've just disabled the test by commenting them out. If you want to deploy and not get prompted to re-import the test (which is the default behavior), you can add --skip-tests to the robotpy deploy command.

Portnord commented 9 months ago

There seems to be a bug with the basic pyfrc tests. The action will run the test step forever.

I've also encountered this bug when deploying to the physical bot. For now, I've just disabled the test by commenting them out. If you want to deploy and not get prompted to re-import the test (which is the default behavior), you can add --skip-tests to the robotpy deploy command.

How long did you wait? That last test_practice apparently runs through an entire practice match, so it would take at least 3 and a half minutes.

NathanGrenier commented 9 months ago

How long did you wait? That last test_practice apparently runs through an entire practice match, so it would take at least 3 and a half minutes.

The runner was alive for ~5 minutes.

Can you link where you read that the test runs through an entire game?

Portnord commented 9 months ago

How long did you wait? That last test_practice apparently runs through an entire practice match, so it would take at least 3 and a half minutes.

The runner was alive for ~5 minutes.

Can you link where you read that the test runs through an entire game?

https://robotpy.readthedocs.io/projects/pyfrc/en/stable/testing.html#pyfrc.tests.basic.test_practice

Instead of loading by skipping tests can we include the one dummy test that does something like 'assert True'? It doesn't run the robot so it shouldn't hang any servers, but it would leave the hook in the folder structure to add testing later.

NathanGrenier commented 9 months ago

Instead of loading by skipping tests can we include the one dummy test that does something like 'assert True'? It doesn't run the robot so it shouldn't hang any servers, but it would leave the hook in the folder structure to add testing later.

I tried that (I already had a sample test) and it still hung indefinitely.

NathanGrenier commented 9 months ago

I ran the tests on the develop branch and they all ran perfectly. Not sure if the infinitely running tests issue was caused by moving all the code to /src or by some other code that was added to implement the drivebase.

Portnord commented 9 months ago

Applied these changes manually to feature/drivebase, tested and merged. This branch and pull request are no longer needed.

sonic-howl / frc2024