search

sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
84 stars 91 forks source link

fix for https://github.com/sonic-net/DASH/issues/454 #455

Closed mgheorghe closed 8 months ago

mgheorghe commented 1 year ago

eni was not very descriptive and one could assume it is the eni object id, updated the name to clearly specify it is the eni mac

fixes https://github.com/sonic-net/DASH/issues/454

r12f commented 1 year ago

looks like The dash sonic hld is moving to sonic repo while DASH repo will link to the sonic one as reference, so I wonder if we could make the change there. both prince and i should be able to help sign off: https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md.

and here is the PR that I am refering to: https://github.com/sonic-net/DASH/pull/447.

KrisNey-MSFT commented 9 months ago

do not merge yet or cancel

mgheorghe commented 8 months ago

canceling, was a misunderstanding