search

sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
83 stars 90 forks source link

Fix set_tunnel #467

Closed marian-pritsak closed 10 months ago

marian-pritsak commented 10 months ago

Pass encapsulation type as parameter to set_tunnel instead of overriding what upper functions got.

marian-pritsak commented 10 months ago

@KrisNey-MSFT Can you please assign reviewers?

KrisNey-MSFT commented 10 months ago

For sure...

From: Marian Pritsak @.> Sent: Tuesday, November 28, 2023 11:25 AM To: sonic-net/DASH @.> Cc: Kristina Moore @.>; Mention @.> Subject: Re: [sonic-net/DASH] Fix set_tunnel (PR #467)

@KrisNey-MSFThttps://github.com/KrisNey-MSFT Can you please assign reviewers?

- Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/DASH/pull/467#issuecomment-1830436896, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6HLN4DXTATQ5NJQG5DYGYT6DAVCNFSM6AAAAAA76FYQFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGQZTMOBZGY. You are receiving this because you were mentioned.Message ID: @.**@.>>

r12f commented 10 months ago

wow... and lgtm! thanks Marian!