Closed r12f closed 8 months ago
PR is not ready for review. Need to discuss what is the right way for libsai changes. My feeling is to convert the input to optional, because this is what BMv2 supports.
discussed in today's DASH BM meeting today. For BMv2, we will convert the ACL input to optional by taking the first item of the list.
OK, the tests are fixed now. this PR is ready for review. @marian-pritsak @kcudnik
This PR changes 3 things:
match_type
annotation for match keys, so we can fix theoptional
match kind that we use to make P4 compiler happy.The end results is shown as below. The comment and type are now updated to the same as opencompute SAI:
(no changes showing up in git diff)
To compare with previous generated content:
Header files:
libsai (creating adapter that converts list / range list to optional for bmv2):