sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
80 stars 89 forks source link

[sai-gen] Add order annotation for attributes to support ordering SAI attributes for ABI compatibility #497

Closed r12f closed 8 months ago

r12f commented 8 months ago

Problem

Currently, DASH SAI attributes are generated based on the order of table keys and action parameters. When multiple types of objects are mixed together, adding a new attributes could cause new SAI attributes being inserted in the middle of the attribute list and breaks the ABI compatibility.

What are we doing in this change

This change introduces 2 things:

The current change will not change the generated content today, as screenshot shows below: image

r12f commented 8 months ago

thanks Marian!