search

sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
78 stars 88 forks source link

Add Flow API Abstraction Implementation #524

Closed zhixiongniu closed 1 week ago

zhixiongniu commented 4 months ago

So sorry, I accidentally closed https://github.com/sonic-net/DASH/pull/507. This PR achieves same thing as https://github.com/sonic-net/DASH/pull/507 and I am adopting all comments from that PR.

This PR introduces the abstraction of the DASH Flow API, encompassing both the flow table and flow entry, within the bmv2 environment.

For a preview of the SAI introduced by this PR, please refer to the following branch: SAI Flow API Preview Branch.

KrisNey-MSFT commented 1 week ago

Did you need some help with this @zhixiongniu ? Let us know!

chrispsommers commented 1 week ago

Pipeline error is here: https://github.com/sonic-net/DASH/actions/runs/9779327816/job/26998305213#step:9:15

SAI specs have changed, please run "make sai-headers" locally and commit the changes for review.

KrisNey-MSFT commented 1 week ago

[heart] Kristina Moore reacted to your message:

From: Chris Sommers @.> Sent: Wednesday, July 10, 2024 4:13:17 PM To: sonic-net/DASH @.> Cc: Kristina Moore @.>; Comment @.> Subject: Re: [sonic-net/DASH] Add flow API Abstraction Implementation (PR #524)

Pipeline error is here: https://github.com/sonic-net/DASH/actions/runs/9779327816/job/26998305213#step:9:15

SAI specs have changed, please run "make sai-headers" locally and commit the changes for review.

— Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/DASH/pull/524#issuecomment-2220940753, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6GVLWHQWNRRJS6Q5V3ZLVMR3AVCNFSM6AAAAABD2OCC72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHE2DANZVGM. You are receiving this because you commented.Message ID: @.***>

zhixiongniu commented 1 week ago

Did you need some help with this @zhixiongniu ? Let us know!

Thanks, I have fixed the issue.

zhixiongniu commented 1 week ago

Pipeline error is here: https://github.com/sonic-net/DASH/actions/runs/9779327816/job/26998305213#step:9:15

SAI specs have changed, please run "make sai-headers" locally and commit the changes for review.

Thanks, I have fixed the issue.

KrisNey-MSFT commented 1 week ago

Awesome - thanks!

From: Zhixiong @.> Sent: Wednesday, July 10, 2024 8:41 PM To: sonic-net/DASH @.> Cc: Kristina Moore @.>; Comment @.> Subject: Re: [sonic-net/DASH] Add flow API Abstraction Implementation (PR #524)

Did you need some help with this @zhixiongniuhttps://github.com/zhixiongniu ? Let us know!

Thanks, I have fixed the issue.

- Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/DASH/pull/524#issuecomment-2221957432, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6AMLC6DIR7JZEY3TDLZLX5D7AVCNFSM6AAAAABD2OCC72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRHE2TONBTGI. You are receiving this because you commented.Message ID: @.**@.>>

KrisNey-MSFT commented 1 week ago

@r12f looks like all checks have passed - is it ready for a merge?

r12f commented 1 week ago

Yep! I think so, it looks aligned with the HLD design now. Is it ok if I approved and merge it?

I checked with Marian offline, and he has no problem on this PR as well, but he is OOF recently, so maybe late on the sign-off.

KrisNey-MSFT commented 1 week ago

Yep! I think so, it looks aligned with the HLD design now. Is it ok if I approved and merge it?

I checked with Marian offline, and he has no problem on this PR as well, but he is OOF recently, so maybe late on the sign-off.

Sounds good to me, go ahead

r12f commented 1 week ago

Thanks Kristina!