search

sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
78 stars 88 forks source link

[dash-p4] Remove original overlay IP from encap data and reuse the existing fields. #529

Closed r12f closed 4 months ago

r12f commented 4 months ago

The original overlay dip/sip looks to be redundant and can directly reuse the overlay data we already have in the metadata, hence doing this change.

KrisNey-MSFT commented 4 months ago

hey @jafingerhut - did this look ok to you (for merge)?

jafingerhut commented 4 months ago

@KrisNey-MSFT Executive summary: I am OK with merging this, but that does not provide much higher assurance that these are the changes you want.

Gory details: For the functional correctness of the changes according to the desired data plane behavior for the DASH project, I am not the best person to review this, unfortunately.

For whether it compiles and runs on P4 DPDK, I believe Chris Sommers has created Github actions/workflow stuff that automatically checks whether it compiles without error, but the various DASH blocking issue for P4 DPDK prevent us from automating checks that pass packets through. Those checks for BMv2 should both compile and pass packets through on every commit, I believe.