Fix entry action search in saiapi.cpp.j2

sonic-net / DASH

Disaggregated APIs for SONiC Hosts

Apache License 2.0

77 stars 88 forks source link

Fix entry action search in saiapi.cpp.j2 #558

Closed marian-pritsak closed 1 month ago

marian-pritsak commented 2 months ago

The refactoring introduced in https://github.com/sonic-net/DASH/pull/438 only looks for a proper action attribute in SAI objects, not entries. In case of SAI entry, it iterates through all the attributes and matches the values regardless of attribute ID.

This PR aligns action search for both objects and entries, and adds action ID attributes to missing create_entry calls in tests.

r12f commented 2 months ago

hi Marian, do you mind to summary a bit on the background of this PR?

marian-pritsak commented 2 months ago

hi Marian, do you mind to summary a bit on the background of this PR?

Done.