search

sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
77 stars 88 forks source link

Change Optional to Ternary in dash_acl.p4 #575

Open KrisNey-MSFT opened 1 month ago

KrisNey-MSFT commented 1 month ago

https://github.com/sonic-net/DASH/blob/e39249bf647aba16736991364052706bea3176c8/dash-pipeline/bmv2/dash_acl.p4#L22

Per our Community discussion today, could we change 'optional' to 'ternary' ?

Opening Issue per @marian-pritsak , @mgheorghe , and @r12f

KrisNey-MSFT commented 1 week ago

This work is going to take some time and it also changes the attributes of the ACL table too (ternary match will add a priority attribute, which is not in design), so it will require a larger change to get it addressed. (Why are we not using 'priority' from the beginning)? Libraries to make this work w/bmv2 will need to be updated (template updates). We may also hit some test issues as well.
Kristina closing PR, but will keep Issue open.