sonic-net / DASH

Disaggregated APIs for SONiC Hosts
Apache License 2.0
77 stars 88 forks source link

[sai-gen] Maintaining the order of SAI enum types. #594

Closed r12f closed 2 weeks ago

r12f commented 2 weeks ago

Since P4 compiler won't maintain the order of the generated enums in p4runtime, it causes all enum values moves around in the code review. Since the enum types from P4 doesn't have any dependencies to each other, we can merge the new enum values into the current SAI spec by appending to the end of the list, just like other SAI attributes.

Additionally, to maintain the SAI ABI, we will not remove any existing enum values too.