Closed dgsudharsan closed 1 year ago
orchagent/vxlanorch.cpp#L2218
if (!tunnel_obj->isActive())
{
++ return false;
-- tunnel_obj->createTunnel(MAP_T::VRID_TO_VNI, MAP_T::VNI_TO_VRID);
}
As part of Vlan to VNI mapping, createTunnelHw() will be called and isActive() will be set. createTunnel() can be replaced with createTunnelHw().
As part of Vlan to VNI mapping, createTunnelHw() will be called and isActive() will be set.
Thanks. Can you please fix this flow and raise PR?
Description
When VRF – VNI mapping arrives before VLAN – VNI mapping (It happens all the time during config reload), the VxLAN tunnel gets created with just VRF to VNI mapper. This is an issue because the encap mappers and decap mappers are create only attributes in tunnel and cannot be added when vlan to vni mapping arrives later. In all other places VLAN to VNI and VRF to VNI are created together and set in tunnel. Is the below case intentional or should be fixed? I also see the createTunnel is used only in this place and all other places use createTunnelHw which almost has same functionality. Should createTunnel be removed?
https://github.com/Azure/sonic-swss/blob/93af69c5cb9a78465604974b59d1b1ed709d2b10/orchagent/vxlanorch.cpp#L2220
Steps to reproduce the issue:
Describe the results you received:
VLAN to VNI mapping creation fails
Describe the results you expected:
VLAN to VNI mapping should succeed
Output of
show version
:Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):