search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
711 stars 1.36k forks source link

bgp service starts in default namespace on multi-asic platform #11653

Closed SuvarnaMeenakshi closed 2 years ago

SuvarnaMeenakshi commented 2 years ago

Description

Steps to reproduce the issue:

  1. boot up multi-asic vs image (sonic-4asic-vs.img.gz ./testbed-cli.sh -t vtestbed.yaml -m veos_vtb -k ceos add-topo vms-kvm-four-asic-t1-lag password.txt
  2. load minigraph ./testbed-cli.sh -t vtestbed.yaml -m veos_vtb deploy-mg vms-kvm-four-asic-t1-lag veos_vtb password.txt
  3. monit complains due to "Unexpected container : bgp"

Describe the results you received:

Before load_minigraph or deploy_mg:

admin@sonic:~$ sudo systemctl status bgp
● bgp.service - BGP container
     Loaded: loaded (/lib/systemd/system/bgp.service; disabled; vendor preset: >
     Active: inactive (dead)
admin@sonic:~$ docker ps
CONTAINER ID   IMAGE                             COMMAND                  CREATED          STATUS          PORTS     NAMES
874c18cbe50b   docker-gbsyncd-vs:latest          "/usr/local/bin/supe…"   21 seconds ago   Up 20 seconds             gbsyncd0
760a826357e7   docker-gbsyncd-vs:latest          "/usr/local/bin/supe…"   22 seconds ago   Up 20 seconds             gbsyncd1
0a93779922b3   docker-gbsyncd-vs:latest          "/usr/local/bin/supe…"   22 seconds ago   Up 20 seconds             gbsyncd2
587b7485d21c   docker-gbsyncd-vs:latest          "/usr/local/bin/supe…"   22 seconds ago   Up 20 seconds             gbsyncd3
00032fb63848   docker-router-advertiser:latest   "/usr/bin/docker-ini…"   24 seconds ago   Up 23 seconds             radv
ac9ff59f8fcd   docker-fpm-frr:latest             "/usr/bin/docker_ini…"   24 seconds ago   Up 23 seconds             bgp1
fc2e20507acb   docker-fpm-frr:latest             "/usr/bin/docker_ini…"   25 seconds ago   Up 23 seconds             bgp2
e02082349927   docker-fpm-frr:latest             "/usr/bin/docker_ini…"   25 seconds ago   Up 23 seconds             bgp0
0ae1e0ae2c38   docker-fpm-frr:latest             "/usr/bin/docker_ini…"   25 seconds ago   Up 23 seconds             bgp3
f63f082e418b   docker-database:latest            "/usr/local/bin/dock…"   31 seconds ago   Up 29 seconds             database3
e2868d30b241   docker-database:latest            "/usr/local/bin/dock…"   31 seconds ago   Up 29 seconds             database0
b77ae03d6564   docker-database:latest            "/usr/local/bin/dock…"   31 seconds ago   Up 29 seconds             database1
6af8a1e65ed3   docker-database:latest            "/usr/local/bin/dock…"   31 seconds ago   Up 29 seconds             database2
80afde6f41d9   docker-database:latest            "/usr/local/bin/dock…"   36 seconds ago   Up 35 seconds             database
admin@sonic:~$

After load minigraph:

admin@sonic:~$ sudo systemctl status bgp
● bgp.service - BGP container
     Loaded: loaded (/lib/systemd/system/bgp.service; disabled; vendor preset: >
     Active: active (running) since Tue 2022-08-09 01:43:56 UTC; 26s ago
   Main PID: 20367 (bgp.sh)
      Tasks: 3 (limit: 8836)

 admin@sonic:~$ docker ps | grep bgp
98176639286b   docker-fpm-frr:latest                "/usr/bin/docker_ini…"   59 seconds ago       Up 56 seconds                 bgp
e0f5596041bd   docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About a minute ago   Up About a minute             bgp1
e8ff4913a02d   docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About a minute ago   Up About a minute             bgp0
2d0058749368   docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About a minute ago   Up About a minute             bgp3
a1639beb13c6   docker-fpm-frr:latest                "/usr/bin/docker_ini…"   About a minute ago   Up About a minute             bgp2

Describe the results you expected:

bgp service should not start up

Output of show version:

admin@sonic:~$ show version

SONiC Software Version: SONiC.master.132197-83db796b0
Distribution: Debian 11.4
Kernel: 5.10.0-12-2-amd64
Build commit: 83db796b0
Build date: Sun Aug  7 23:19:31 UTC 2022
Built by: AzDevOps@sonic-build-workers-001W69

Platform: x86_64-kvm_x86_64_4_asic-r0
HwSKU: msft_four_asic_vs
ASIC: vs
ASIC Count: 4
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 01:45:31 up 8 min,  1 user,  load average: 2.22, 2.01, 0.97
Date: Tue 09 Aug 2022 01:45:31

Docker images:
REPOSITORY                    TAG                       IMAGE ID       SIZE
docker-orchagent              latest                    7372636a8a9f   475MB
docker-orchagent              master.132197-83db796b0   7372636a8a9f   475MB
docker-teamd                  latest                    29f2b0c329ef   456MB
docker-teamd                  master.132197-83db796b0   29f2b0c329ef   456MB
docker-macsec                 latest                    8d45823ae5df   458MB
docker-gbsyncd-vs             latest                    7c94fc845ef3   448MB
docker-gbsyncd-vs             master.132197-83db796b0   7c94fc845ef3   448MB
docker-dhcp-relay             latest                    39b31a77de11   450MB
docker-sonic-telemetry        latest                    43761a86d773   521MB
docker-sonic-telemetry        master.132197-83db796b0   43761a86d773   521MB
docker-platform-monitor       latest                    021705079718   562MB
docker-platform-monitor       master.132197-83db796b0   021705079718   562MB
docker-router-advertiser      latest                    421074c4da0a   440MB
docker-router-advertiser      master.132197-83db796b0   421074c4da0a   440MB
docker-mux                    latest                    1e88d5511e7f   489MB
docker-mux                    master.132197-83db796b0   1e88d5511e7f   489MB
docker-database               latest                    f646aa0b16bb   440MB
docker-database               master.132197-83db796b0   f646aa0b16bb   440MB
docker-fpm-frr                latest                    56a9974ceec5   458MB
docker-fpm-frr                master.132197-83db796b0   56a9974ceec5   458MB
docker-sflow                  latest                    02674751ea68   429MB
docker-sflow                  master.132197-83db796b0   02674751ea68   429MB
docker-nat                    latest                    cb4baa079861   431MB
docker-nat                    master.132197-83db796b0   cb4baa079861   431MB
docker-sonic-mgmt-framework   latest                    7b26202fd3ad   558MB
docker-sonic-mgmt-framework   master.132197-83db796b0   7b26202fd3ad   558MB
docker-snmp                   latest                    19c78ef3e624   457MB
docker-snmp                   master.132197-83db796b0   19c78ef3e624   457MB
docker-syncd-vs               latest                    b94c845ef3d7   426MB
docker-syncd-vs               master.132197-83db796b0   b94c845ef3d7   426MB
docker-lldp                   latest                    bd669b9c0bad   454MB
docker-lldp                   master.132197-83db796b0   bd669b9c0bad   454MB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

SuvarnaMeenakshi commented 2 years ago

@wenyiz2021

SuvarnaMeenakshi commented 2 years ago

caused due to https://github.com/sonic-net/sonic-buildimage/pull/11000

Ndancejic commented 2 years ago

updated #11000 with a fix, please confirm that this works for multi-asic systems

Ndancejic commented 2 years ago

https://github.com/sonic-net/sonic-buildimage/pull/11691

SuvarnaMeenakshi commented 2 years ago

Issue fixed with https://github.com/sonic-net/sonic-buildimage/pull/11691