search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
735 stars 1.41k forks source link

[EVPN VXLAN] Orchagent crash when removing a Vlan that is mapped to VNI #11944

Closed dellwuchuan closed 2 years ago

dellwuchuan commented 2 years ago

Description

The issue is that when remove a VLAN which is mapped to VNI, FRR docker would crash. The CLI shouldn't allow it.

Steps to reproduce the issue:

Steps:

config vlan add 1000

config vlan member add 1000 Ethernet60

config vxlan map add vtep101032 1000 7385123

config vlan member del 1000 Ethernet60

config vlan del 1000 -----> This should throw error since there is vxlan map but it doesn't leading to orchagent crash

Describe the results you received:

FRR docker would crash: Error response from daemon: Container bdc5e2d094f015ef1a8a390983df23c9ec15292cc4c2aef5760e40e869f94b1d is not running

Describe the results you expected:

FRR docker should not crash

Output of show version:

show version

SONiC Software Version: SONiC.202205_rc.5-e9edd6649_Internal Distribution: Debian 11.4 Kernel: 5.10.0-12-2-amd64 Build commit: e9edd6649 Build date: Wed Aug 24 07:25:38 UTC 2022 Built by: sw-r2d2-bot@r-build-sonic02-006

Platform: x86_64-mlnx_msn3700c-r0 HwSKU: ACS-MSN3700C ASIC: mellanox ASIC Count: 1 Serial Number: MT1922X00258 Model Number: MSN3700-CS2FO Hardware Revision: A4 Uptime: 05:15:12 up 12:46, 3 users, load average: 1.68, 1.41, 1.20 Date: Fri 02 Sep 2022 05:15:12

Docker images: REPOSITORY TAG IMAGE ID SIZE docker-orchagent 202205_rc.5-e9edd6649_Internal e9433676d577 473MB docker-orchagent latest e9433676d577 473MB docker-teamd 202205_rc.5-e9edd6649_Internal b2f411cd8bf9 454MB docker-teamd latest b2f411cd8bf9 454MB docker-macsec latest aafbd270e937 456MB docker-platform-monitor 202205_rc.5-e9edd6649_Internal 1acbdbf06a99 856MB docker-platform-monitor latest 1acbdbf06a99 856MB docker-syncd-mlnx 202205_rc.5-e9edd6649_Internal bd817fe4be10 853MB docker-syncd-mlnx latest bd817fe4be10 853MB docker-dhcp-relay latest 3698d39df346 447MB docker-sonic-telemetry 202205_rc.5-e9edd6649_Internal 155c1ddce3d7 518MB docker-sonic-telemetry latest 155c1ddce3d7 518MB docker-lldp 202205_rc.5-e9edd6649_Internal d3fcdf1896c2 480MB docker-lldp latest d3fcdf1896c2 480MB docker-database 202205_rc.5-e9edd6649_Internal 242c18d7aadb 438MB docker-database latest 242c18d7aadb 438MB docker-mux 202205_rc.5-e9edd6649_Internal 3d086b179393 487MB docker-mux latest 3d086b179393 487MB docker-router-advertiser 202205_rc.5-e9edd6649_Internal 3a587ce79289 438MB docker-router-advertiser latest 3a587ce79289 438MB docker-fpm-frr 202205_rc.5-e9edd6649_Internal 62274c8e5005 456MB docker-fpm-frr latest 62274c8e5005 456MB docker-snmp 202205_rc.5-e9edd6649_Internal 984469f006dc 455MB docker-snmp latest 984469f006dc 455MB docker-nat 202205_rc.5-e9edd6649_Internal eb2f12581524 429MB docker-nat latest eb2f12581524 429MB docker-sflow 202205_rc.5-e9edd6649_Internal 70b48b050c5b 428MB docker-sflow latest 70b48b050c5b 428MB docker-sonic-mgmt-framework 202205_rc.5-e9edd6649_Internal 383b88a99bda 556MB docker-sonic-mgmt-framework latest 383b88a99bda 556MB urm.nvidia.com/sw-nbu-sws-sonic-docker/sonic-wjh 1.3.0-202205-internal-16 710c8ce56a84 495MB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

dgsudharsan commented 2 years ago

@adyeung Can you please assign someone to fix this?

adyeung commented 2 years ago

Will push a CLI check to block the VLAN del if there is an existing VLAN VNI mapping associated. Expect a fix by end of Sept

adyeung commented 2 years ago

Will be fixed by https://github.com/sonic-net/sonic-utilities/pull/2388

adyeung commented 2 years ago

Resolved by #2388