Open AlanYoush opened 1 year ago
Reassign to DELL team as discussed offline
looks like this issue came from this commit, @liuh-80 can you please check it. https://github.com/sonic-net/sonic-buildimage/pull/11215
@mhampasagar , swsssdk been deprecated. This issue caused by a API gap between swss-common and redis-py: In swss-common: https://github.com/sonic-net/sonic-swss-common/blob/2247dbea47f968411b28b5c04d4be89d72d08cbf/common/pubsub.h void psubscribe(const std::string &pattern);
In redis-py: https://github.com/redis/redis-py/blob/a94772848db87bfc2c3cee20d8ca8b257fc37466/redis/asyncio/client.py async def psubscribe(self, *args: ChannelT, **kwargs: PubSubHandler):
I will create a PR to fix this and similar issue ASAP.
Fix PR created: https://github.com/sonic-net/sonic-buildimage/pull/13836
@jeff-yin, could you please review the fix for this issue? https://github.com/sonic-net/sonic-buildimage/pull/13836
Description
I find that function "self.pubsub.psubscribe()" return error of getting unexpected arguments. Because pubsub.psubscribe() is defined in swsscommon.swsscommon rather than swsssdk. The argument of pubsub.psubscribe() in swsscommon.swsscommon is "string &pattern"
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Output of
show version
:Master Version
Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):